Reachability: use NSURLSession for MacOS 10.14 or higher #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@absaroj, @eduardo-camacho - Can you help in reviewing this. Thanks. |
|
@absaroj , @eduardo-camacho : Reminder to review code for Mac/iOS |
absaroj
reviewed
Feb 13, 2025
abuhsayem
force-pushed
the
user/asayem/1ds_reachability
branch
from
8c32fe3 to
2b63632
Compare
abuhsayem
force-pushed
the
user/asayem/1ds_reachability
branch
from
710bfd3 to
6924349
Compare
|
Hi @eduardo-camacho and @absaroj, @abuhsayem has been waiting for review on this for some time. Could one of you review soon please? |
absaroj
reviewed
May 6, 2025
| { | ||
| // Use URLSession for macOS 10.14 or higher | ||
| NSString *formattedHostname = hostname; | ||
| if (![formattedHostname hasPrefix:@"https://"] && ![formattedHostname hasPrefix:@"http://"]) { |
There was a problem hiding this comment.
would just checking with "http" prefix be enough?
absaroj
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reachability uses SCNetworkReachabilityRef library which is deprecated in MacOS 10.14 or higher.
Hence, Use NSURLSession for MacOS 10.14 or higher in cpp_client_telemetry/third_party/Reachability and have backward compatibility with SCNetworkReachabilityRef library for versions lower than MacOS 10.14